From 3c05071aef475b6f286e1925883c3844cab43e89 Mon Sep 17 00:00:00 2001 From: Nick Lewis Date: Wed, 21 Aug 2013 16:52:52 -0700 Subject: [PATCH] Sort list of metrics and metrics data This makes the metrics a lot easier to scan, because it groups similar metrics (like all the HTTP metrics) as well as the percentiles, etc. --- puppetboard/app.py | 4 ++-- puppetboard/templates/metric.html | 2 +- puppetboard/templates/metrics.html | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/puppetboard/app.py b/puppetboard/app.py index 0fbf684..14689c7 100644 --- a/puppetboard/app.py +++ b/puppetboard/app.py @@ -202,9 +202,9 @@ def metrics(): metrics = puppetdb._query('metrics', path='mbeans') for key,value in metrics.iteritems(): metrics[key]=value.split('/')[3] - return render_template('metrics.html', metrics=metrics) + return render_template('metrics.html', metrics=sorted(metrics.items())) @app.route('/metric/') def metric(metric): metric = puppetdb.metric(metric) - return render_template('metric.html', metric=metric) + return render_template('metric.html', metric=sorted(metric.items())) diff --git a/puppetboard/templates/metric.html b/puppetboard/templates/metric.html index 8e2aba6..17f60cf 100644 --- a/puppetboard/templates/metric.html +++ b/puppetboard/templates/metric.html @@ -3,7 +3,7 @@

Metric

- {% for key,value in metric.iteritems() %} + {% for key,value in metric %} diff --git a/puppetboard/templates/metrics.html b/puppetboard/templates/metrics.html index 8f84658..cf90e13 100644 --- a/puppetboard/templates/metrics.html +++ b/puppetboard/templates/metrics.html @@ -2,7 +2,7 @@ {% block content %}

Metrics

{{key}} {{value}}