Extend spec test to all package types

spec/types/entropy_mask_spec.rb

@@ -1,81 +0,0 @@
-require 'spec_helper'
-
-describe Puppet::Type.type(:entropy_mask) do
-  before do
-    @provider = stub 'provider'
-    @provider.stubs(:name).returns(:parsed)
-    @provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
-    @provider.stubs(:default_target).returns("defaulttarget")
-    described_class.stubs(:defaultprovider).returns(@provider)
-  end
-
-  it "should be an instance of Puppet::Type::Entropy_mask" do
-    expect(described_class.new(:name => "test", :package => "app-admin/dummy")).to be_an_instance_of Puppet::Type::Entropy_mask
-  end
-
-  describe "when validating attributes" do
-    params     = [:name]
-    properties = [:package, :operator, :version, :slot, :use, :tag, :repo, :target]
-
-    params.each do |param|
-      it "should have the #{param} param" do
-        expect(described_class.attrtype(param)).to eq :param
-      end
-    end
-
-    properties.each do |property|
-      it "should have the #{property} property" do
-        expect(described_class.attrtype(property)).to eq :property
-      end
-    end
-
-  end
-
-  it "should have name as the namevar" do
-    expect(described_class.key_attributes).to eq [:name]
-  end
-
-  describe "when validating the target property" do
-    it "should default to the provider's default target" do
-      expect(described_class.new(:name => "test", :package => "app-admin/dummy").should(:target)).to eq "defaulttarget"
-    end
-  end
-
-  describe "when validating required properties" do
-    it "should raise an error when no required attributes are passed" do
-      expect {
-        described_class.new(:name => "test")
-      }.to raise_error(Puppet::Error, /At least one of (.*) is required/)
-    end
-
-    it "should raise an error when a version is passed with no package" do
-      expect {
-        described_class.new(:name => "test", :repo => "test", :version => "1.2.3")
-      }.to raise_error(Puppet::Error, /Package is required/)
-    end
-
-    it "should raise an error when an operator is passed with no version" do
-      expect {
-        described_class.new(:name => "test", :package => "app-admin/dummy", :operator => "<=")
-      }.to raise_error(Puppet::Error, /Version is required/)
-    end
-  end
-
-  describe "when the catalog includes a matching package" do
-    it "should have an autobefore relationship" do
-      mask = described_class.new(:name => "test", :package => "app-admin/dummy")
-      package = Puppet::Type.type(:package).new(:title => 'app-admin/dummy')
-
-      catalog = Puppet::Resource::Catalog.new
-      catalog.add_resource package
-      catalog.add_resource mask
-
-      befores = mask.autobefore
-      expect(befores.size).to eq 1
-      expect(befores[0].source).to eq mask
-      expect(befores[0].target).to eq package
-    end
-  end
-end
-
-# vim: set ts=2 sw=2 expandtab:

spec/types/package_types_spec.rb

@@ -0,0 +1,94 @@
+require 'spec_helper'
+require 'puppet/type/entropy_mask'
+require 'puppet/type/entropy_unmask'
+require 'puppet/type/entropy_splitdebug'
+require 'puppet/type/entropy_splitdebug_mask'
+
+types = {
+    :entropy_mask            => Puppet::Type::Entropy_mask,
+    :entropy_unmask          => Puppet::Type::Entropy_unmask,
+    :entropy_splitdebug      => Puppet::Type::Entropy_splitdebug,
+    :entropy_splitdebug_mask => Puppet::Type::Entropy_splitdebug_mask,
+}
+
+types.each do |type_name, type|
+  describe Puppet::Type.type(type_name) do
+    before do
+      @provider = stub 'provider'
+      @provider.stubs(:name).returns(:parsed)
+      @provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
+      @provider.stubs(:default_target).returns("defaulttarget")
+      described_class.stubs(:defaultprovider).returns(@provider)
+    end
+
+    it "should be an instance of #{type.class.name}" do
+      expect(described_class.new(:name => "test", :package => "app-admin/dummy")).to be_an_instance_of type
+    end
+
+    describe "when validating attributes" do
+      params     = [:name]
+      properties = [:package, :operator, :version, :slot, :use, :tag, :repo, :target]
+
+      params.each do |param|
+        it "should have the #{param} param" do
+          expect(described_class.attrtype(param)).to eq :param
+        end
+      end
+
+      properties.each do |property|
+        it "should have the #{property} property" do
+          expect(described_class.attrtype(property)).to eq :property
+        end
+      end
+
+    end
+
+    it "should have name as the namevar" do
+      expect(described_class.key_attributes).to eq [:name]
+    end
+
+    describe "when validating the target property" do
+      it "should default to the provider's default target" do
+        expect(described_class.new(:name => "test", :package => "app-admin/dummy").should(:target)).to eq "defaulttarget"
+      end
+    end
+
+    describe "when validating required properties" do
+      it "should raise an error when no required attributes are passed" do
+        expect {
+          described_class.new(:name => "test")
+        }.to raise_error(Puppet::Error, /At least one of (.*) is required/)
+      end
+
+      it "should raise an error when a version is passed with no package" do
+        expect {
+          described_class.new(:name => "test", :repo => "test", :version => "1.2.3")
+        }.to raise_error(Puppet::Error, /Package is required/)
+      end
+
+      it "should raise an error when an operator is passed with no version" do
+        expect {
+          described_class.new(:name => "test", :package => "app-admin/dummy", :operator => "<=")
+        }.to raise_error(Puppet::Error, /Version is required/)
+      end
+    end
+
+    describe "when the catalog includes a matching package" do
+      it "should have an autobefore relationship" do
+        resource = described_class.new(:name => "test", :package => "app-admin/dummy")
+        package = Puppet::Type.type(:package).new(:title => 'app-admin/dummy')
+
+        catalog = Puppet::Resource::Catalog.new
+        catalog.add_resource package
+        catalog.add_resource resource
+
+        befores = resource.autobefore
+        expect(befores.size).to eq 1
+        expect(befores[0].source).to eq resource
+        expect(befores[0].target).to eq package
+      end
+    end
+  end
+end
+
+# vim: set ts=2 sw=2 expandtab: