Autocorrect PDK validation warnings

spec/unit/provider/entropy_keywords/parsed_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
-  before do
+  before(:each) do
     described_class.stubs(:filetype).returns(Puppet::Util::FileType::FileTypeRam)
     described_class.stubs(:filetype=)
     @default_target = described_class.default_target
@@ -14,7 +14,7 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
   end
 
   describe 'when parsing' do
-    it 'should parse out the name' do
+    it 'parses out the name' do
       line = '** app-admin/foobar ## Puppet Name: foobar'
       expect(described_class.parse_line(line)[:name]).to eq('foobar')
     end
@@ -23,15 +23,15 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       line = '** app-admin/foobar ## Puppet Name: foobar'
       parsed = described_class.parse_line(line)
 
-      it 'should parse out the keyword' do
+      it 'parses out the keyword' do
         expect(parsed[:keyword]).to eq('**')
       end
 
-      it 'should parse out the package name' do
+      it 'parses out the package name' do
         expect(parsed[:package]).to eq('app-admin/foobar')
       end
 
-      it 'should have all other parameters undefined' do
+      it 'has all other parameters undefined' do
         [:operator, :version, :repo].each do |param|
           expect(parsed[param]).to be_nil
         end
@@ -42,19 +42,19 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       line = '** app-admin/foobar-1.2.3_alpha1-r1 ## Puppet Name: foobar'
       parsed = described_class.parse_line(line)
 
-      it 'should parse out the keyword' do
+      it 'parses out the keyword' do
         expect(parsed[:keyword]).to eq('**')
       end
 
-      it 'should parse out the package name' do
+      it 'parses out the package name' do
         expect(parsed[:package]).to eq('app-admin/foobar')
       end
 
-      it 'should parse out the version' do
+      it 'parses out the version' do
         expect(parsed[:version]).to eq('1.2.3_alpha1-r1')
       end
 
-      it 'should have all other parameters undefined' do
+      it 'has all other parameters undefined' do
         [:operator, :repo].each do |param|
           expect(parsed[param]).to be_nil
         end
@@ -65,23 +65,23 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       line = '** >=app-admin/foobar-1.2.3_alpha1-r1 ## Puppet Name: foobar'
       parsed = described_class.parse_line(line)
 
-      it 'should parse out the keyword' do
+      it 'parses out the keyword' do
         expect(parsed[:keyword]).to eq('**')
       end
 
-      it 'should parse out the package name' do
+      it 'parses out the package name' do
         expect(parsed[:package]).to eq('app-admin/foobar')
       end
 
-      it 'should parse out the version' do
+      it 'parses out the version' do
         expect(parsed[:version]).to eq('1.2.3_alpha1-r1')
       end
 
-      it 'should parse out the operator' do
+      it 'parses out the operator' do
         expect(parsed[:operator]).to eq('>=')
       end
 
-      it 'should have all other parameters undefined' do
+      it 'has all other parameters undefined' do
         [:repo].each do |param|
           expect(parsed[param]).to be_nil
         end
@@ -92,19 +92,19 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       line = '** app-admin/foobar repo=community ## Puppet Name: foobar'
       parsed = described_class.parse_line(line)
 
-      it 'should parse out the keyword' do
+      it 'parses out the keyword' do
         expect(parsed[:keyword]).to eq('**')
       end
 
-      it 'should parse out the package name' do
+      it 'parses out the package name' do
         expect(parsed[:package]).to eq('app-admin/foobar')
       end
 
-      it 'should parse out the repo' do
+      it 'parses out the repo' do
         expect(parsed[:repo]).to eq('community')
       end
 
-      it 'should have all other parameters undefined' do
+      it 'has all other parameters undefined' do
         [:operator, :version].each do |param|
           expect(parsed[param]).to be_nil
         end
@@ -115,15 +115,15 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       line = 'amd64 repo=community ## Puppet Name: foobar'
       parsed = described_class.parse_line(line)
 
-      it 'should parse out the keyword' do
+      it 'parses out the keyword' do
         expect(parsed[:keyword]).to eq('amd64')
       end
 
-      it 'should parse out the repo' do
+      it 'parses out the repo' do
         expect(parsed[:repo]).to eq('community')
       end
 
-      it 'should have all other parameters undefined' do
+      it 'has all other parameters undefined' do
         [:package, :operator, :version].each do |param|
           expect(parsed[param]).to be_nil
         end
@@ -135,24 +135,23 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       parsed = described_class.parse_line(line)
 
       expected = {
-        :name     => 'foobar',
-        :keyword  => '**',
-        :package  => 'app-admin/foobar',
-        :operator => '>=',
-        :version  => '1.2.3a_alpha1-r1',
-        :repo     => 'community',
+        name: 'foobar',
+        keyword: '**',
+        package: 'app-admin/foobar',
+        operator: '>=',
+        version: '1.2.3a_alpha1-r1',
+        repo: 'community',
       }
 
-      it 'should parse out all parameters' do
+      it 'parses out all parameters' do
         expected.each do |param, value|
           expect(parsed[param]).to eq(value)
         end
       end
     end
-
   end
 
-  describe 'when flushing' do 
+  describe 'when flushing' do
     before :each do
       @ramfile = Puppet::Util::FileType::FileTypeRam.new(@default_target)
       File.stubs(:exist?).with(@default_target).returns(true)
@@ -163,71 +162,71 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
       described_class.clear
     end
 
-    it 'should output a single package entry' do
+    it 'outputs a single package entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :package     => 'app-admin/foobar',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        package: 'app-admin/foobar',
       }
-      expect(described_class.to_line(resource)).to eq ('** app-admin/foobar ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** app-admin/foobar ## Puppet Name: test'
     end
 
-    it 'should output a versioned package entry' do
+    it 'outputs a versioned package entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :package     => 'app-admin/foobar',
-        :version     => '1.2.3',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        package: 'app-admin/foobar',
+        version: '1.2.3',
       }
-      expect(described_class.to_line(resource)).to eq ('** app-admin/foobar-1.2.3 ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** app-admin/foobar-1.2.3 ## Puppet Name: test'
     end
 
-    it 'should output a ranged versioned package entry' do
+    it 'outputs a ranged versioned package entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :package     => 'app-admin/foobar',
-        :version     => '1.2.3',
-        :operator    => '>=',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        package: 'app-admin/foobar',
+        version: '1.2.3',
+        operator: '>=',
       }
-      expect(described_class.to_line(resource)).to eq ('** >=app-admin/foobar-1.2.3 ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** >=app-admin/foobar-1.2.3 ## Puppet Name: test'
     end
 
-    it 'should output a repo-specific package entry' do
+    it 'outputs a repo-specific package entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :package     => 'app-admin/foobar',
-        :repo        => 'community',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        package: 'app-admin/foobar',
+        repo: 'community',
       }
-      expect(described_class.to_line(resource)).to eq ('** app-admin/foobar repo=community ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** app-admin/foobar repo=community ## Puppet Name: test'
     end
 
-    it 'should output a whole-repo entry' do
+    it 'outputs a whole-repo entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :repo        => 'community',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        repo: 'community',
       }
-      expect(described_class.to_line(resource)).to eq ('** repo=community ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** repo=community ## Puppet Name: test'
     end
 
-    it 'should output all fields for a package entry' do
+    it 'outputs all fields for a package entry' do
       resource = {
-        :record_type => :parsed,
-        :name        => 'test',
-        :keyword     => '**',
-        :package     => 'app-admin/foobar',
-        :operator    => '>=',
-        :version     => '1.2.3',
-        :repo        => 'community',
+        record_type: :parsed,
+        name: 'test',
+        keyword: '**',
+        package: 'app-admin/foobar',
+        operator: '>=',
+        version: '1.2.3',
+        repo: 'community',
       }
-      expect(described_class.to_line(resource)).to eq ('** >=app-admin/foobar-1.2.3 repo=community ## Puppet Name: test')
+      expect(described_class.to_line(resource)).to eq '** >=app-admin/foobar-1.2.3 repo=community ## Puppet Name: test'
     end
   end
 end