Rubocop fixes

spec/unit/provider/entropy_keywords/parsed_spec.rb

@@ -1,10 +1,11 @@
 require 'spec_helper'
 
 describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
+  let(:default_target) { described_class.default_target }
+
   before(:each) do
     described_class.stubs(:filetype).returns(Puppet::Util::FileType::FileTypeRam)
     described_class.stubs(:filetype=)
-    @default_target = described_class.default_target
   end
 
   describe 'should have a default target of /etc/entropy/packages/package.keywords' do
@@ -152,10 +153,11 @@ describe Puppet::Type.type(:entropy_keywords).provider(:parsed) do
   end
 
   describe 'when flushing' do
+    let(:ramfile) { Puppet::Util::FileType::FileTypeRam.new(:default_target) }
+
     before :each do
-      @ramfile = Puppet::Util::FileType::FileTypeRam.new(@default_target)
-      File.stubs(:exist?).with(@default_target).returns(true)
-      described_class.any_instance.stubs(:target_object).returns(@ramfile)
+      File.stubs(:exist?).with(:default_target).returns(true)
+      described_class.stubs(:target_object).returns(:ramfile)
     end
 
     after :each do

spec/unit/provider/package_types/parsed_spec.rb

@@ -20,10 +20,11 @@ default_targets = {
 
 types.each do |type_name, _type|
   describe Puppet::Type.type(type_name).provider(:parsed) do
+    let(:default_target) { described_class.default_target }
+
     before(:each) do
       described_class.stubs(:filetype).returns(Puppet::Util::FileType::FileTypeRam)
       described_class.stubs(:filetype=)
-      @default_target = described_class.default_target
     end
 
     describe "should have a default target of #{default_targets[type_name]}" do
@@ -195,10 +196,13 @@ types.each do |type_name, _type|
     end
 
     describe 'when flushing' do
+      let(:ramfile) do
+        Puppet::Util::FileType::FileTypeRam.new(:default_target)
+      end
+
       before :each do
-        @ramfile = Puppet::Util::FileType::FileTypeRam.new(@default_target)
         File.stubs(:exist?).with(default_targets[type_name]).returns(true)
-        described_class.any_instance.stubs(:target_object).returns(@ramfile)
+        described_class.stubs(:target_object).returns(:ramfile)
       end
 
       after :each do

spec/unit/type/enman_repo_spec.rb

@@ -1,8 +1,8 @@
 describe Puppet::Type.type(:enman_repo) do
   before(:each) do
-    @provider = stub 'provider'
-    @provider.stubs(:name).returns(:enman)
-    described_class.stubs(:defaultprovider).returns(@provider)
+    provider = stub 'provider'
+    provider.stubs(:name).returns(:enman)
+    described_class.stubs(:defaultprovider).returns(provider)
   end
 
   it 'is an instance of Puppet::Type::Enman_repo' do

spec/unit/type/entropy_keywords_spec.rb

@@ -1,10 +1,10 @@
 describe Puppet::Type.type(:entropy_keywords) do
   before(:each) do
-    @provider = stub 'provider'
-    @provider.stubs(:name).returns(:parsed)
-    @provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
-    @provider.stubs(:default_target).returns('defaulttarget')
-    described_class.stubs(:defaultprovider).returns(@provider)
+    provider = stub 'provider'
+    provider.stubs(:name).returns(:parsed)
+    provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
+    provider.stubs(:default_target).returns('defaulttarget')
+    described_class.stubs(:defaultprovider).returns(provider)
   end
 
   it 'is an instance of Puppet::Type::Entropy_keywords' do

spec/unit/type/entropy_repo_spec.rb

@@ -1,8 +1,8 @@
 describe Puppet::Type.type(:entropy_repo) do
   before(:each) do
-    @provider = stub 'provider'
-    @provider.stubs(:name).returns(:file)
-    described_class.stubs(:defaultprovider).returns(@provider)
+    provider = stub 'provider'
+    provider.stubs(:name).returns(:file)
+    described_class.stubs(:defaultprovider).returns(provider)
   end
 
   it 'is an instance of Puppet::Type::Entropy_repo' do

spec/unit/type/package_types_spec.rb

@@ -14,11 +14,11 @@ types = {
 types.each do |type_name, type|
   describe Puppet::Type.type(type_name) do
     before(:each) do
-      @provider = stub 'provider'
-      @provider.stubs(:name).returns(:parsed)
-      @provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
-      @provider.stubs(:default_target).returns('defaulttarget')
-      described_class.stubs(:defaultprovider).returns(@provider)
+      provider = stub 'provider'
+      provider.stubs(:name).returns(:parsed)
+      provider.stubs(:ancestors).returns([Puppet::Provider::ParsedFile])
+      provider.stubs(:default_target).returns('defaulttarget')
+      described_class.stubs(:defaultprovider).returns(provider)
     end
 
     it "should be an instance of #{type.class.name}" do