Add unit tests

vendor/github.com/osrg/gobgp/pkg/server/rpki.go

@@ -20,7 +20,6 @@ import (
 	"fmt"
 	"io"
 	"net"
-	"sort"
 	"strconv"
 	"time"
 
@@ -29,99 +28,51 @@ import (
 	"github.com/osrg/gobgp/pkg/packet/bgp"
 	"github.com/osrg/gobgp/pkg/packet/rtr"
 
-	"github.com/armon/go-radix"
 	log "github.com/sirupsen/logrus"
 	"golang.org/x/net/context"
 )
 
 const (
-	CONNECT_RETRY_INTERVAL = 30
+	connectRetryInterval = 30
 )
 
 func before(a, b uint32) bool {
 	return int32(a-b) < 0
 }
 
-type RoaBucket struct {
-	Prefix  *table.IPPrefix
-	entries []*table.ROA
-}
-
-func (r *RoaBucket) GetEntries() []*table.ROA {
-	return r.entries
-}
-
-type roas []*table.ROA
-
-func (r roas) Len() int {
-	return len(r)
-}
-
-func (r roas) Swap(i, j int) {
-	r[i], r[j] = r[j], r[i]
-}
-
-func (r roas) Less(i, j int) bool {
-	r1 := r[i]
-	r2 := r[j]
-
-	if r1.MaxLen < r2.MaxLen {
-		return true
-	} else if r1.MaxLen > r2.MaxLen {
-		return false
-	}
-
-	if r1.AS < r2.AS {
-		return true
-	}
-	return false
-}
-
-type ROAEventType uint8
+type roaEventType uint8
 
 const (
-	CONNECTED ROAEventType = iota
-	DISCONNECTED
-	RTR
-	LIFETIMEOUT
+	roaConnected roaEventType = iota
+	roaDisconnected
+	roaRTR
+	roaLifetimeout
 )
 
-type ROAEvent struct {
-	EventType ROAEventType
+type roaEvent struct {
+	EventType roaEventType
 	Src       string
 	Data      []byte
 	conn      *net.TCPConn
 }
 
 type roaManager struct {
-	AS        uint32
-	Roas      map[bgp.RouteFamily]*radix.Tree
-	eventCh   chan *ROAEvent
+	eventCh   chan *roaEvent
 	clientMap map[string]*roaClient
+	table     *table.ROATable
 }
 
-func NewROAManager(as uint32) (*roaManager, error) {
+func newROAManager(table *table.ROATable) *roaManager {
 	m := &roaManager{
-		AS:   as,
-		Roas: make(map[bgp.RouteFamily]*radix.Tree),
+		eventCh:   make(chan *roaEvent),
+		clientMap: make(map[string]*roaClient),
+		table:     table,
 	}
-	m.Roas[bgp.RF_IPv4_UC] = radix.New()
-	m.Roas[bgp.RF_IPv6_UC] = radix.New()
-	m.eventCh = make(chan *ROAEvent)
-	m.clientMap = make(map[string]*roaClient)
-	return m, nil
+	return m
 }
 
-func (c *roaManager) enabled() bool {
-	return len(c.clientMap) != 0
-}
-
-func (m *roaManager) SetAS(as uint32) error {
-	if m.AS != 0 {
-		return fmt.Errorf("AS was already configured")
-	}
-	m.AS = as
-	return nil
+func (m *roaManager) enabled() bool {
+	return len(m.clientMap) != 0
 }
 
 func (m *roaManager) AddServer(host string, lifetime int64) error {
@@ -135,7 +86,7 @@ func (m *roaManager) AddServer(host string, lifetime int64) error {
 	if _, ok := m.clientMap[host]; ok {
 		return fmt.Errorf("ROA server exists %s", host)
 	}
-	m.clientMap[host] = NewRoaClient(address, port, m.eventCh, lifetime)
+	m.clientMap[host] = newRoaClient(address, port, m.eventCh, lifetime)
 	return nil
 }
 
@@ -145,35 +96,11 @@ func (m *roaManager) DeleteServer(host string) error {
 		return fmt.Errorf("ROA server doesn't exists %s", host)
 	}
 	client.stop()
-	m.deleteAllROA(host)
+	m.table.DeleteAll(host)
 	delete(m.clientMap, host)
 	return nil
 }
 
-func (m *roaManager) deleteAllROA(network string) {
-	for _, tree := range m.Roas {
-		deleteKeys := make([]string, 0, tree.Len())
-		tree.Walk(func(s string, v interface{}) bool {
-			b, _ := v.(*RoaBucket)
-			newEntries := make([]*table.ROA, 0, len(b.entries))
-			for _, r := range b.entries {
-				if r.Src != network {
-					newEntries = append(newEntries, r)
-				}
-			}
-			if len(newEntries) > 0 {
-				b.entries = newEntries
-			} else {
-				deleteKeys = append(deleteKeys, s)
-			}
-			return false
-		})
-		for _, key := range deleteKeys {
-			tree.Delete(key)
-		}
-	}
-}
-
 func (m *roaManager) Enable(address string) error {
 	for network, client := range m.clientMap {
 		add, _, _ := net.SplitHostPort(network)
@@ -190,7 +117,7 @@ func (m *roaManager) Disable(address string) error {
 		add, _, _ := net.SplitHostPort(network)
 		if add == address {
 			client.reset()
-			m.deleteAllROA(add)
+			m.table.DeleteAll(add)
 			return nil
 		}
 	}
@@ -206,35 +133,35 @@ func (m *roaManager) SoftReset(address string) error {
 		add, _, _ := net.SplitHostPort(network)
 		if add == address {
 			client.softReset()
-			m.deleteAllROA(network)
+			m.table.DeleteAll(network)
 			return nil
 		}
 	}
 	return fmt.Errorf("ROA server not found %s", address)
 }
 
-func (c *roaManager) ReceiveROA() chan *ROAEvent {
-	return c.eventCh
+func (m *roaManager) ReceiveROA() chan *roaEvent {
+	return m.eventCh
 }
 
 func (c *roaClient) lifetimeout() {
-	c.eventCh <- &ROAEvent{
-		EventType: LIFETIMEOUT,
+	c.eventCh <- &roaEvent{
+		EventType: roaLifetimeout,
 		Src:       c.host,
 	}
 }
 
-func (m *roaManager) HandleROAEvent(ev *ROAEvent) {
+func (m *roaManager) HandleROAEvent(ev *roaEvent) {
 	client, y := m.clientMap[ev.Src]
 	if !y {
-		if ev.EventType == CONNECTED {
+		if ev.EventType == roaConnected {
 			ev.conn.Close()
 		}
 		log.WithFields(log.Fields{"Topic": "rpki"}).Errorf("Can't find %s ROA server configuration", ev.Src)
 		return
 	}
 	switch ev.EventType {
-	case DISCONNECTED:
+	case roaDisconnected:
 		log.WithFields(log.Fields{"Topic": "rpki"}).Infof("ROA server %s is disconnected", ev.Src)
 		client.state.Downtime = time.Now().Unix()
 		// clear state
@@ -245,14 +172,14 @@ func (m *roaManager) HandleROAEvent(ev *ROAEvent) {
 		go client.tryConnect()
 		client.timer = time.AfterFunc(time.Duration(client.lifetime)*time.Second, client.lifetimeout)
 		client.oldSessionID = client.sessionID
-	case CONNECTED:
+	case roaConnected:
 		log.WithFields(log.Fields{"Topic": "rpki"}).Infof("ROA server %s is connected", ev.Src)
 		client.conn = ev.conn
 		client.state.Uptime = time.Now().Unix()
 		go client.established()
-	case RTR:
+	case roaRTR:
 		m.handleRTRMsg(client, &client.state, ev.Data)
-	case LIFETIMEOUT:
+	case roaLifetimeout:
 		// a) already reconnected but hasn't received
 		// EndOfData -> needs to delete stale ROAs
 		// b) not reconnected -> needs to delete stale ROAs
@@ -264,83 +191,17 @@ func (m *roaManager) HandleROAEvent(ev *ROAEvent) {
 			log.WithFields(log.Fields{"Topic": "rpki"}).Infof("Reconnected to %s. Ignore timeout", client.host)
 		} else {
 			log.WithFields(log.Fields{"Topic": "rpki"}).Infof("Deleting all ROAs due to timeout with:%s", client.host)
-			m.deleteAllROA(client.host)
+			m.table.DeleteAll(client.host)
 		}
 	}
 }
 
-func (m *roaManager) roa2tree(roa *table.ROA) (*radix.Tree, string) {
-	tree := m.Roas[bgp.RF_IPv4_UC]
-	if roa.Family == bgp.AFI_IP6 {
-		tree = m.Roas[bgp.RF_IPv6_UC]
-	}
-	return tree, table.IpToRadixkey(roa.Prefix.Prefix, roa.Prefix.Length)
-}
-
-func (m *roaManager) deleteROA(roa *table.ROA) {
-	tree, key := m.roa2tree(roa)
-	b, _ := tree.Get(key)
-	if b != nil {
-		bucket := b.(*RoaBucket)
-		newEntries := make([]*table.ROA, 0, len(bucket.entries))
-		for _, r := range bucket.entries {
-			if !r.Equal(roa) {
-				newEntries = append(newEntries, r)
-			}
-		}
-		if len(newEntries) != len(bucket.entries) {
-			bucket.entries = newEntries
-			if len(newEntries) == 0 {
-				tree.Delete(key)
-			}
-			return
-		}
-	}
-	log.WithFields(log.Fields{
-		"Topic":         "rpki",
-		"Prefix":        roa.Prefix.Prefix.String(),
-		"Prefix Length": roa.Prefix.Length,
-		"AS":            roa.AS,
-		"Max Length":    roa.MaxLen,
-	}).Info("Can't withdraw a ROA")
-}
-
-func (m *roaManager) DeleteROA(roa *table.ROA) {
-	m.deleteROA(roa)
-}
-
-func (m *roaManager) addROA(roa *table.ROA) {
-	tree, key := m.roa2tree(roa)
-	b, _ := tree.Get(key)
-	var bucket *RoaBucket
-	if b == nil {
-		bucket = &RoaBucket{
-			Prefix:  roa.Prefix,
-			entries: make([]*table.ROA, 0),
-		}
-		tree.Insert(key, bucket)
-	} else {
-		bucket = b.(*RoaBucket)
-		for _, r := range bucket.entries {
-			if r.Equal(roa) {
-				// we already have the same one
-				return
-			}
-		}
-	}
-	bucket.entries = append(bucket.entries, roa)
-}
-
-func (m *roaManager) AddROA(roa *table.ROA) {
-	m.addROA(roa)
-}
-
-func (c *roaManager) handleRTRMsg(client *roaClient, state *config.RpkiServerState, buf []byte) {
+func (m *roaManager) handleRTRMsg(client *roaClient, state *config.RpkiServerState, buf []byte) {
 	received := &state.RpkiMessages.RpkiReceived
 
-	m, err := rtr.ParseRTR(buf)
+	m1, err := rtr.ParseRTR(buf)
 	if err == nil {
-		switch msg := m.(type) {
+		switch msg := m1.(type) {
 		case *rtr.RTRSerialNotify:
 			if before(client.serialNumber, msg.RTRCommon.SerialNumber) {
 				client.enable(client.serialNumber)
@@ -367,19 +228,19 @@ func (c *roaManager) handleRTRMsg(client *roaClient, state *config.RpkiServerSta
 			roa := table.NewROA(family, msg.Prefix, msg.PrefixLen, msg.MaxLen, msg.AS, client.host)
 			if (msg.Flags & 1) == 1 {
 				if client.endOfData {
-					c.addROA(roa)
+					m.table.Add(roa)
 				} else {
 					client.pendingROAs = append(client.pendingROAs, roa)
 				}
 			} else {
-				c.deleteROA(roa)
+				m.table.Delete(roa)
 			}
 		case *rtr.RTREndOfData:
 			received.EndOfData++
 			if client.sessionID != msg.RTRCommon.SessionID {
 				// remove all ROAs related with the
 				// previous session
-				c.deleteAllROA(client.host)
+				m.table.DeleteAll(client.host)
 			}
 			client.sessionID = msg.RTRCommon.SessionID
 			client.serialNumber = msg.RTRCommon.SerialNumber
@@ -389,7 +250,7 @@ func (c *roaManager) handleRTRMsg(client *roaClient, state *config.RpkiServerSta
 				client.timer = nil
 			}
 			for _, roa := range client.pendingROAs {
-				c.addROA(roa)
+				m.table.Add(roa)
 			}
 			client.pendingROAs = make([]*table.ROA, 0)
 		case *rtr.RTRCacheReset:
@@ -407,34 +268,12 @@ func (c *roaManager) handleRTRMsg(client *roaClient, state *config.RpkiServerSta
 	}
 }
 
-func (c *roaManager) GetServers() []*config.RpkiServer {
-	f := func(tree *radix.Tree) (map[string]uint32, map[string]uint32) {
-		records := make(map[string]uint32)
-		prefixes := make(map[string]uint32)
+func (m *roaManager) GetServers() []*config.RpkiServer {
+	recordsV4, prefixesV4 := m.table.Info(bgp.RF_IPv4_UC)
+	recordsV6, prefixesV6 := m.table.Info(bgp.RF_IPv6_UC)
 
-		tree.Walk(func(s string, v interface{}) bool {
-			b, _ := v.(*RoaBucket)
-			tmpRecords := make(map[string]uint32)
-			for _, roa := range b.entries {
-				tmpRecords[roa.Src]++
-			}
-
-			for src, r := range tmpRecords {
-				if r > 0 {
-					records[src] += r
-					prefixes[src]++
-				}
-			}
-			return false
-		})
-		return records, prefixes
-	}
-
-	recordsV4, prefixesV4 := f(c.Roas[bgp.RF_IPv4_UC])
-	recordsV6, prefixesV6 := f(c.Roas[bgp.RF_IPv6_UC])
-
-	l := make([]*config.RpkiServer, 0, len(c.clientMap))
-	for _, client := range c.clientMap {
+	l := make([]*config.RpkiServer, 0, len(m.clientMap))
+	for _, client := range m.clientMap {
 		state := &client.state
 
 		if client.conn == nil {
@@ -468,128 +307,11 @@ func (c *roaManager) GetServers() []*config.RpkiServer {
 	return l
 }
 
-func (c *roaManager) GetRoa(family bgp.RouteFamily) ([]*table.ROA, error) {
-	if len(c.clientMap) == 0 {
-		return []*table.ROA{}, fmt.Errorf("RPKI server isn't configured.")
-	}
-	var rfList []bgp.RouteFamily
-	switch family {
-	case bgp.RF_IPv4_UC:
-		rfList = []bgp.RouteFamily{bgp.RF_IPv4_UC}
-	case bgp.RF_IPv6_UC:
-		rfList = []bgp.RouteFamily{bgp.RF_IPv6_UC}
-	default:
-		rfList = []bgp.RouteFamily{bgp.RF_IPv4_UC, bgp.RF_IPv6_UC}
-	}
-	l := make([]*table.ROA, 0)
-	for _, rf := range rfList {
-		if tree, ok := c.Roas[rf]; ok {
-			tree.Walk(func(s string, v interface{}) bool {
-				b, _ := v.(*RoaBucket)
-				var roaList roas
-				for _, r := range b.entries {
-					roaList = append(roaList, r)
-				}
-				sort.Sort(roaList)
-				for _, roa := range roaList {
-					l = append(l, roa)
-				}
-				return false
-			})
-		}
-	}
-	return l, nil
-}
-
-func ValidatePath(ownAs uint32, tree *radix.Tree, cidr string, asPath *bgp.PathAttributeAsPath) *table.Validation {
-	var as uint32
-
-	validation := &table.Validation{
-		Status:          config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND,
-		Reason:          table.RPKI_VALIDATION_REASON_TYPE_NONE,
-		Matched:         make([]*table.ROA, 0),
-		UnmatchedLength: make([]*table.ROA, 0),
-		UnmatchedAs:     make([]*table.ROA, 0),
-	}
-
-	if asPath == nil || len(asPath.Value) == 0 {
-		as = ownAs
-	} else {
-		param := asPath.Value[len(asPath.Value)-1]
-		switch param.GetType() {
-		case bgp.BGP_ASPATH_ATTR_TYPE_SEQ:
-			asList := param.GetAS()
-			if len(asList) == 0 {
-				as = ownAs
-			} else {
-				as = asList[len(asList)-1]
-			}
-		case bgp.BGP_ASPATH_ATTR_TYPE_CONFED_SET, bgp.BGP_ASPATH_ATTR_TYPE_CONFED_SEQ:
-			as = ownAs
-		default:
-			return validation
-		}
-	}
-	_, n, _ := net.ParseCIDR(cidr)
-	ones, _ := n.Mask.Size()
-	prefixLen := uint8(ones)
-	key := table.IpToRadixkey(n.IP, prefixLen)
-	_, b, _ := tree.LongestPrefix(key)
-	if b == nil {
-		return validation
-	}
-
-	var bucket *RoaBucket
-	fn := radix.WalkFn(func(k string, v interface{}) bool {
-		bucket, _ = v.(*RoaBucket)
-		for _, r := range bucket.entries {
-			if prefixLen <= r.MaxLen {
-				if r.AS != 0 && r.AS == as {
-					validation.Matched = append(validation.Matched, r)
-				} else {
-					validation.UnmatchedAs = append(validation.UnmatchedAs, r)
-				}
-			} else {
-				validation.UnmatchedLength = append(validation.UnmatchedLength, r)
-			}
-		}
-		return false
-	})
-	tree.WalkPath(key, fn)
-
-	if len(validation.Matched) != 0 {
-		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_VALID
-		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_NONE
-	} else if len(validation.UnmatchedAs) != 0 {
-		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_INVALID
-		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_AS
-	} else if len(validation.UnmatchedLength) != 0 {
-		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_INVALID
-		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_LENGTH
-	} else {
-		validation.Status = config.RPKI_VALIDATION_RESULT_TYPE_NOT_FOUND
-		validation.Reason = table.RPKI_VALIDATION_REASON_TYPE_NONE
-	}
-
-	return validation
-}
-
-func (c *roaManager) validate(path *table.Path) *table.Validation {
-	if len(c.clientMap) == 0 || path.IsWithdraw || path.IsEOR() {
-		// RPKI isn't enabled or invalid path
-		return nil
-	}
-	if tree, ok := c.Roas[path.GetRouteFamily()]; ok {
-		return ValidatePath(c.AS, tree, path.GetNlri().String(), path.GetAsPath())
-	}
-	return nil
-}
-
 type roaClient struct {
 	host         string
 	conn         *net.TCPConn
 	state        config.RpkiServerState
-	eventCh      chan *ROAEvent
+	eventCh      chan *roaEvent
 	sessionID    uint16
 	oldSessionID uint16
 	serialNumber uint32
@@ -601,7 +323,7 @@ type roaClient struct {
 	ctx          context.Context
 }
 
-func NewRoaClient(address, port string, ch chan *ROAEvent, lifetime int64) *roaClient {
+func newRoaClient(address, port string, ch chan *roaEvent, lifetime int64) *roaClient {
 	ctx, cancel := context.WithCancel(context.Background())
 	c := &roaClient{
 		host:        net.JoinHostPort(address, port),
@@ -663,10 +385,10 @@ func (c *roaClient) tryConnect() {
 		}
 		if conn, err := net.Dial("tcp", c.host); err != nil {
 			// better to use context with timeout
-			time.Sleep(CONNECT_RETRY_INTERVAL * time.Second)
+			time.Sleep(connectRetryInterval * time.Second)
 		} else {
-			c.eventCh <- &ROAEvent{
-				EventType: CONNECTED,
+			c.eventCh <- &roaEvent{
+				EventType: roaConnected,
 				Src:       c.host,
 				conn:      conn.(*net.TCPConn),
 			}
@@ -678,8 +400,8 @@ func (c *roaClient) tryConnect() {
 func (c *roaClient) established() (err error) {
 	defer func() {
 		c.conn.Close()
-		c.eventCh <- &ROAEvent{
-			EventType: DISCONNECTED,
+		c.eventCh <- &roaEvent{
+			EventType: roaDisconnected,
 			Src:       c.host,
 		}
 	}()
@@ -703,8 +425,8 @@ func (c *roaClient) established() (err error) {
 			return
 		}
 
-		c.eventCh <- &ROAEvent{
-			EventType: RTR,
+		c.eventCh <- &roaEvent{
+			EventType: roaRTR,
 			Src:       c.host,
 			Data:      append(header, body...),
 		}